Skip to content

Conversation

@beNative
Copy link
Owner

Summary

  • recompute SHA-512 hashes for Windows installer and blockmap artifacts during normalization
  • update manifest rewriting to rename ia32 assets, refresh metadata, and retain both manifests
  • allow checksum refresh even when only x64 artifacts are present

Testing

  • npm test

Codex Task

@beNative beNative merged commit 4eb4aa7 into main Nov 11, 2025
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

if (inPackagesSection) {
const packagePathMatch = line.match(/^\s{4}path:\s+(.*)$/);
if (packagePathMatch) {
const rawValue = packagePathMatch[1];
const updatedValue = replaceWithRename(rawValue);
if (updatedValue !== rawValue) {
lines[index] = line.replace(rawValue, updatedValue);
}
currentPackageFileKey = toBasename(updatedValue);
continue;
}
const packageShaMatch = line.match(/^(\s{4}sha512:\s+).*/);
if (packageShaMatch) {
lines[index] = applyHashIfAvailable(line, currentPackageFileKey, /^(\s{4}sha512:\s+).*/);

P1 Badge Refresh package checksums without assuming path fields

The checksum refresh in updateManifestFile never updates the packages section. currentPackageFileKey is only populated when a line matches ^\s{4}path: (lines 133‑141), but Electron’s Windows latest.yml normally represents packages as objects keyed by architecture (e.g. packages:\n x64:\n sha512: …) and does not emit a path property. In that common format the subsequent sha512 lines (lines 145‑147) execute with currentPackageFileKey === null, so their hashes are left unchanged even though the file’s SHA‑512 was recomputed above. Update clients that read packages.*.sha512 will continue to see stale checksums and may reject the release. Consider deriving the key from the package name (e.g. the preceding architecture label) or at least recomputing hashes for these entries too.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants